Skip to content

fix: Update push_data annotation with JsonSerializable instead of Any#899

Merged
vdusek merged 9 commits into
apify:masterfrom
Mantisus:test-json-typing
May 26, 2026
Merged

fix: Update push_data annotation with JsonSerializable instead of Any#899
vdusek merged 9 commits into
apify:masterfrom
Mantisus:test-json-typing

Conversation

@Mantisus
Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus commented May 15, 2026 •
edited
Loading

@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented May 15, 2026

@vdusek, well, it caused issues, and we should update the SDK typing after Crawlee is updated.

@Mantisus Mantisus changed the title fix: test crawlee typing updates fix: Update push_data annotation with JsonSerializable instead of Any May 18, 2026
@vdusek
Copy link
Copy Markdown
Contributor

vdusek commented May 25, 2026

Hi @Mantisus , could you please make this ready for a review? Let's release a patch of Crawlee, and the last patch of SDK, and then jump into BCs for SDK v4 🙂 .

@Mantisus Mantisus marked this pull request as ready for review May 25, 2026 22:19
@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented May 25, 2026

Hi @Mantisus , could you please make this ready for a review? Let's release a patch of Crawlee, and the last patch of SDK, and then jump into BCs for SDK v4 🙂 .

It's ready, but we need to release the crawlee patch first so I can unlink it from the master branch. 🙂

@vdusek
Copy link
Copy Markdown
Contributor

vdusek commented May 26, 2026

Makes sense. I was waiting for apify/crawlee-python#1904 to be merged. Now there is v1.7.1 - and just please refresh the lock file without bumping the constraints in pyproject.toml. If I am not mistaken, this isn't a runtime issue, only type checking, so we don't want to constrain versions over it.

vdusek
vdusek approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented May 26, 2026

If I am not mistaken, this isn't a runtime issue, only type checking, so we don't want to constrain versions over it.

Right. Updated lock file.

@vdusek vdusek merged commit b4f5485 into apify:master May 26, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mantisus @vdusek @apify-service-account